Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 893213002: Revert of Make GL bindings conditional (Closed)

Created:
5 years, 10 months ago by Daniel Kurtz
Modified:
5 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make GL bindings conditional (patchset #12 id:120001 of https://codereview.chromium.org/871763002/) Reason for revert: Suspected of breaking WebGL on ARM (Mali) Chrome OS. BUG=454816 Original issue's description: > Make GL bindings conditional > > In addition to the extensions also parse GL/GLES version > information from the headers (hence add a few fresh headers). > > Instead of brute-forcing binding in somewhat unclear order > make all dynamic bindings very specifically conditional to > the GL version or extension, given the precise name. > If a function is not available, then leave function pointer > set to NULL so it will generate a crash (report). > (Previously it might have ended up as 0 > or with whatever valid or not valid pointer GetProcAddr() > returned - i.e. GetProcAddr returning something does not > imply the functionality is there.) > > The version also includes whether it is GLES or not which > means we won't look up functions on GLES anymore that are > specific to desktop or vice versa. > > Update gpu_unittests so that they are very specific to what > extensions they need (otherwise they might end up calling > the _NotBound fallback). > > Also make WGL/GLX/EGL/MESA bindings all happen rightaway since > they don't depend on a context. > > BUG=438742, 325668 > > Committed: https://crrev.com/e3b17fd533b81a9855a28d04894021479cd6d89d > Cr-Commit-Position: refs/heads/master@{#313663} TBR=kbr@chromium.org,vmiura@chromium.org,zmo@chromium.org,piman@chromium.org,sievers@chromium.org BUG=438742, 325668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1606 lines, -15894 lines) Patch
M gpu/command_buffer/service/feature_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 10 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_async_pixel.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 7 chunks +14 lines, -35 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 10 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc View 9 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 14 chunks +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 22 chunks +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 chunk +1 line, -11 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_array_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/khronos/README.chromium View 1 chunk +2 lines, -4 lines 0 comments Download
D third_party/khronos/noninclude/GL/glext.h View 1 chunk +0 lines, -11790 lines 0 comments Download
D third_party/khronos/noninclude/GL/glxext.h View 1 chunk +0 lines, -1001 lines 0 comments Download
D third_party/khronos/noninclude/GL/wglext.h View 1 chunk +0 lines, -840 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/generate_bindings.py View 52 chunks +323 lines, -387 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_bindings.h View 2 chunks +4 lines, -14 lines 0 comments Download
D ui/gl/gl_bindings.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M ui/gl/gl_bindings_autogen_egl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings_autogen_egl.cc View 6 chunks +32 lines, -97 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 2 chunks +10 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 15 chunks +989 lines, -1439 lines 0 comments Download
M ui/gl/gl_bindings_autogen_glx.cc View 4 chunks +29 lines, -84 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 6 chunks +16 lines, -10 lines 0 comments Download
M ui/gl/gl_bindings_autogen_osmesa.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings_autogen_wgl.cc View 3 chunks +21 lines, -59 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_mac.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_ozone.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_x11.cc View 1 chunk +8 lines, -1 line 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_version_info.h View 1 chunk +10 lines, -12 lines 0 comments Download
M ui/gl/gl_version_info.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Daniel Kurtz
Created Revert of Make GL bindings conditional
5 years, 10 months ago (2015-02-03 16:13:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893213002/1
5 years, 10 months ago (2015-02-03 16:14:13 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-03 16:14:15 UTC) #4
Zhenyao Mo
We have other CLs landed on top of this one. Just reverting this will definitely ...
5 years, 10 months ago (2015-02-03 17:19:55 UTC) #5
no sievers
We need to fix this (not revert), since this is an urgent M41 blocker for ...
5 years, 10 months ago (2015-02-03 18:40:24 UTC) #6
no sievers
Did you verify that reverting this patch fixes the issue? Because it does not for ...
5 years, 10 months ago (2015-02-03 19:59:59 UTC) #7
no sievers
Should be fixed with https://codereview.chromium.org/887113003/
5 years, 10 months ago (2015-02-04 00:44:51 UTC) #8
Daniel Kurtz
On 2015/02/04 00:44:51, sievers wrote: > Did you verify that reverting this patch fixes the ...
5 years, 10 months ago (2015-02-04 00:46:11 UTC) #9
Zhenyao Mo
5 years, 10 months ago (2015-02-10 23:13:31 UTC) #10
Can we close this CL?  The bug is already fixed, so we no longer need this one.

Powered by Google App Engine
This is Rietveld 408576698