Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 892843002: Add mistagging-readbarrier to weak cell

Created:
5 years, 10 months ago by Erik Corry Chromium.org
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add mistagging-readbarrier to weak cell R=hpayer@chromium.org,ulan@chromium.org BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -49 lines) Patch
M src/globals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +17 lines, -19 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +20 lines, -5 lines 1 comment Download
M src/ic/ia32/handler-compiler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +8 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +49 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Erik Corry Chromium.org
5 years, 10 months ago (2015-02-01 17:03:33 UTC) #1
Erik Corry Chromium.org
Perhaps it would be better to add a boolean field to the weak cell. The ...
5 years, 10 months ago (2015-02-01 17:07:14 UTC) #3
Erik Corry Chromium.org
If we don't want to expand the size of a weak cell, an alternative way ...
5 years, 10 months ago (2015-02-02 12:21:31 UTC) #4
Erik Corry Chromium.org
Alternative approach, PTAL: https://codereview.chromium.org/893073006/
5 years, 10 months ago (2015-02-03 16:13:24 UTC) #5
Hannes Payer (out of office)
5 years, 10 months ago (2015-02-04 13:03:44 UTC) #6
https://codereview.chromium.org/892843002/diff/1/src/ia32/macro-assembler-ia3...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/892843002/diff/1/src/ia32/macro-assembler-ia3...
src/ia32/macro-assembler-ia32.cc:2421: j(not_zero, &done);
Do we need the test? Maybe the cpu is more happy with just untagging. WDYT?

Powered by Google App Engine
This is Rietveld 408576698