src/ia32/macro-assembler-ia32.h - Issue 892843002: Add mistagging-readbarrier to weak cell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.h

Issue 892843002: Add mistagging-readbarrier to weak cell Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.h

diff --git a/src/ia32/macro-assembler-ia32.h b/src/ia32/macro-assembler-ia32.h

index b8c59b70bc23376ffb8f5f6d97e36e3cf229eccf..47cb06cc06bc637f76616594a95579cc662932b9 100644

--- a/src/ia32/macro-assembler-ia32.h

+++ b/src/ia32/macro-assembler-ia32.h

@@ -300,7 +300,8 @@ class MacroAssembler: public Assembler {

// Load the value of the weak cell in the value register. Branch to the given

// miss label if the weak cell was cleared.

- void LoadWeakValue(Register value, Handle<WeakCell> cell, Label* miss);

+ void LoadWeakValue(Register value, Register scratch, Handle<WeakCell> cell,

+ Label* miss);

// ---------------------------------------------------------------------------

// JavaScript invokes