Add mistagging-readbarrier to weak cell

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Review notes:
 //
 // - The use of macros in these inline functions may seem superfluous
 // but it is absolutely needed to make sure gcc generates optimal
 // code. gcc is not happy when attempting to inline too deep.
 //
@@ skipping 1931 matching lines @@
 Object* PropertyCell::type_raw() const {
   return READ_FIELD(this, kTypeOffset);
 }
 
 
 void PropertyCell::set_type_raw(Object* val, WriteBarrierMode ignored) {
   WRITE_FIELD(this, kTypeOffset, val);
 }
 
 
-Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); }
+static const intptr_t kReadBarrierTag = 2;
+static const intptr_t kReadBarrierMask = 2;
+
+
+inline bool HasReadBarrierTag(Object* value) {
+  DCHECK(!HAS_SMI_TAG(value));
+  return (reinterpret_cast<intptr_t>(value) & kReadBarrierMask) ==
+         kReadBarrierTag;
+}
+
+
+inline Object* ReadBarrierTag(Object* value) {
+  DCHECK(!HAS_SMI_TAG(value));
+  intptr_t tagged = reinterpret_cast<intptr_t>(value) | kReadBarrierTag;
+  return reinterpret_cast<Object*>(tagged);
+}
+
+
+inline Object* ReadBarrierUntag(Object* value) {
+  DCHECK(!HAS_SMI_TAG(value));
+  intptr_t untagged = reinterpret_cast<intptr_t>(value) & kReadBarrierTag;
+  return reinterpret_cast<Object*>(untagged);
+}
+
+
+Object* WeakCell::value() {
+  Object* pointer = READ_FIELD(this, kValueOffsetDontForgetTheReadBarrier);
+  if (pointer != Smi::FromInt(0) && HasReadBarrierTag(pointer)) {
+    pointer = ReadBarrierUntag(pointer);
+    WRITE_FIELD(this, kValueOffsetDontForgetTheReadBarrier, pointer);
+  }
+
+  return pointer;
+}
+
+
+Object* WeakCell::ValueNoReadBarrier() {
+  Object* pointer = READ_FIELD(this, kValueOffsetDontForgetTheReadBarrier);
+  if (pointer == Smi::FromInt(0)) return pointer;
+  DCHECK(!pointer->IsSmi());
+  return ReadBarrierUntag(pointer);
+}
 
 
 void WeakCell::clear() {
   DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT);
-  WRITE_FIELD(this, kValueOffset, Smi::FromInt(0));
+  WRITE_FIELD(this, kValueOffsetDontForgetTheReadBarrier, Smi::FromInt(0));
 }
 
 
 void WeakCell::initialize(HeapObject* val) {
-  WRITE_FIELD(this, kValueOffset, val);
-  WRITE_BARRIER(GetHeap(), this, kValueOffset, val);
+  WRITE_FIELD(this, kValueOffsetDontForgetTheReadBarrier, val);
+  WRITE_BARRIER(GetHeap(), this, kValueOffsetDontForgetTheReadBarrier, val);
 }
 
 
-bool WeakCell::cleared() const { return value() == Smi::FromInt(0); }
+bool WeakCell::cleared() const {
+  Object* pointer = READ_FIELD(this, kValueOffsetDontForgetTheReadBarrier);
+  return pointer == Smi::FromInt(0);
+}
 
 
 Object* WeakCell::next() const { return READ_FIELD(this, kNextOffset); }
 
 
 void WeakCell::set_next(Object* val, WriteBarrierMode mode) {
   WRITE_FIELD(this, kNextOffset, val);
   if (mode == UPDATE_WRITE_BARRIER) {
     WRITE_BARRIER(GetHeap(), this, kNextOffset, val);
   }
@@ skipping 5540 matching lines @@
 #undef READ_SHORT_FIELD
 #undef WRITE_SHORT_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 #undef NOBARRIER_READ_BYTE_FIELD
 #undef NOBARRIER_WRITE_BYTE_FIELD
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_INL_H_