Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: src/ic/ia32/handler-compiler-ia32.cc

Issue 892843002: Add mistagging-readbarrier to weak cell Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic/ia32/handler-compiler-ia32.cc
diff --git a/src/ic/ia32/handler-compiler-ia32.cc b/src/ic/ia32/handler-compiler-ia32.cc
index f20d75fba74909fb2863d999c99cd2d8b34f7a03..43d6175af33cb927273820ba9d2f0b93d7667475 100644
--- a/src/ic/ia32/handler-compiler-ia32.cc
+++ b/src/ic/ia32/handler-compiler-ia32.cc
@@ -356,7 +356,7 @@ void NamedStoreHandlerCompiler::GenerateRestoreMap(Handle<Map> transition,
Handle<WeakCell> cell = Map::WeakCellForMap(transition);
Register map_reg = StoreTransitionDescriptor::MapRegister();
DCHECK(!map_reg.is(scratch));
- __ LoadWeakValue(map_reg, cell, miss);
+ __ LoadWeakValue(map_reg, scratch, cell, miss);
if (transition->CanBeDeprecated()) {
__ mov(scratch, FieldOperand(map_reg, Map::kBitField3Offset));
__ and_(scratch, Immediate(Map::Deprecated::kMask));
@@ -729,7 +729,7 @@ Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
// Get the value from the cell.
Register result = StoreDescriptor::ValueRegister();
Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
- __ LoadWeakValue(result, weak_cell, &miss);
+ __ LoadWeakValue(result, scratch1(), weak_cell, &miss);
__ mov(result, FieldOperand(result, PropertyCell::kValueOffset));
// Check for deleted property if property can actually be deleted.

Powered by Google App Engine
This is Rietveld 408576698