Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: src/objects-debug.cc

Issue 892843002: Add mistagging-readbarrier to weak cell Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index e6c231ecc64094ebed85666b5a301fa75f6d4573..7c2a4c28c4e314b0d80acc3109a3e5e359e21a2a 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -9,6 +9,7 @@
#include "src/heap/objects-visiting.h"
#include "src/jsregexp.h"
#include "src/macro-assembler.h"
+#include "src/objects-inl.h"
#include "src/ostreams.h"
namespace v8 {
@@ -647,7 +648,8 @@ void PropertyCell::PropertyCellVerify() {
void WeakCell::WeakCellVerify() {
CHECK(IsWeakCell());
- VerifyObjectField(kValueOffset);
+ Object* value = ValueNoReadBarrier();
+ VerifyPointer(value);
VerifyObjectField(kNextOffset);
}
« src/ia32/macro-assembler-ia32.cc ('K') | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698