Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886173003: VM: Align implementations of assembler constant pools. (Closed)

Created:
5 years, 10 months ago by Florian Schneider
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Align implementations of assembler constant pools. Add Support for adding patchable/non-patchable entries on ARM/MIPS like already done for x64/ARM64. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43589

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : fixed ARM debug assert #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -340 lines) Patch
M runtime/vm/assembler.h View 1 2 chunks +31 lines, -0 lines 2 comments Download
M runtime/vm/assembler.cc View 1 2 1 chunk +59 lines, -0 lines 2 comments Download
M runtime/vm/assembler_arm.h View 1 5 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 8 chunks +8 lines, -62 lines 2 comments Download
M runtime/vm/assembler_arm64.h View 1 4 chunks +2 lines, -16 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 5 chunks +26 lines, -87 lines 2 comments Download
M runtime/vm/assembler_arm_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 5 chunks +5 lines, -12 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 chunks +2 lines, -40 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 4 chunks +2 lines, -16 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 11 chunks +32 lines, -94 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Florian Schneider
https://codereview.chromium.org/886173003/diff/20001/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (left): https://codereview.chromium.org/886173003/diff/20001/runtime/vm/assembler_arm.cc#oldcode2713 runtime/vm/assembler_arm.cc:2713: void Assembler::LoadDecodableImmediate( This function seems redundant (see LoadPatchableImmediate)
5 years, 10 months ago (2015-02-06 12:48:00 UTC) #2
Vyacheslav Egorov (Google)
LGTM https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.h File runtime/vm/assembler.h (right): https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.h#newcode279 runtime/vm/assembler.h:279: private: new line before private https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc ...
5 years, 10 months ago (2015-02-06 15:55:18 UTC) #3
Florian Schneider
https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.h File runtime/vm/assembler.h (right): https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.h#newcode279 runtime/vm/assembler.h:279: private: On 2015/02/06 15:55:18, Vyacheslav Egorov (Google) wrote: > ...
5 years, 10 months ago (2015-02-09 10:25:37 UTC) #4
Florian Schneider
Committed patchset #3 (id:40001) manually as r43589 (presubmit successful).
5 years, 10 months ago (2015-02-09 11:47:51 UTC) #5
zra
https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.cc File runtime/vm/assembler.cc (right): https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.cc#newcode248 runtime/vm/assembler.cc:248: // The object pool cannot be used in the ...
5 years, 10 months ago (2015-02-09 15:30:30 UTC) #6
Florian Schneider
5 years, 10 months ago (2015-02-09 15:49:41 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.cc
File runtime/vm/assembler.cc (right):

https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler.cc#...
runtime/vm/assembler.cc:248: // The object pool cannot be used in the vm
isolate.
On 2015/02/09 15:30:30, zra wrote:
> This comment appears misplaced.

Done.

https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/886173003/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm.cc:2720: LoadPatchableImmediate(rd, value, cond);
On 2015/02/09 15:30:30, zra wrote:
> What is the reason for this change? Does this immediate load now need to be
> patchable? If so, then the first two cases should also be removed. If not,
then
> LoadDecodableImmediate gives a shorter sequence for < 16 bit values.

No, I missed the case for <16 bit values. I'll undo this part.

Powered by Google App Engine
This is Rietveld 408576698