Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: runtime/vm/assembler_arm64.h

Issue 886173003: VM: Align implementations of assembler constant pools. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed ARM debug assert Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm64.h
===================================================================
--- runtime/vm/assembler_arm64.h (revision 43497)
+++ runtime/vm/assembler_arm64.h (working copy)
@@ -475,7 +475,7 @@
ASSERT(buffer_.pointer_offsets().length() == 0); // No pointers in code.
return buffer_.pointer_offsets();
}
- const GrowableObjectArray& object_pool() const { return object_pool_; }
+ const GrowableObjectArray& object_pool() const { return object_pool_.data(); }
bool use_far_branches() const {
return FLAG_use_far_branches || use_far_branches_;
@@ -1299,11 +1299,6 @@
static const int kClosureCallBreakpointCPIndex = 6;
static const int kRuntimeCallBreakpointCPIndex = 7;
- enum Patchability {
- kPatchable,
- kNotPatchable,
- };
-
bool allow_constant_pool() const {
return allow_constant_pool_;
}
@@ -1313,9 +1308,6 @@
void LoadWordFromPoolOffset(Register dst, Register pp, uint32_t offset);
void LoadWordFromPoolOffsetFixed(Register dst, Register pp, uint32_t offset);
- intptr_t FindExternalLabel(const ExternalLabel* label,
- Patchability patchable);
- intptr_t FindObject(const Object& obj, Patchability patchable);
intptr_t FindImmediate(int64_t imm);
bool CanLoadObjectFromPool(const Object& object);
bool CanLoadImmediateFromPool(int64_t imm, Register pp);
@@ -1425,14 +1417,8 @@
AssemblerBuffer buffer_; // Contains position independent code.
// Objects and patchable jump targets.
- GrowableObjectArray& object_pool_;
+ ObjectPool object_pool_;
- // Patchability of pool entries.
- GrowableArray<Patchability> patchable_pool_entries_;
-
- // Hashmap for fast lookup in object pool.
- DirectChainedHashMap<ObjIndexPair> object_pool_index_table_;
-
int32_t prologue_offset_;
bool use_far_branches_;

Powered by Google App Engine
This is Rietveld 408576698