VM: Align implementations of assembler constant pools.

runtime/vm/assembler.h

Index: runtime/vm/assembler.h
===================================================================
--- runtime/vm/assembler.h	(revision 43497)
+++ runtime/vm/assembler.h	(working copy)
@@ -9,6 +9,7 @@
 #include "vm/allocation.h"
 #include "vm/globals.h"
 #include "vm/growable_array.h"
+#include "vm/hash_map.h"
 #include "vm/object.h"
 
 namespace dart {
@@ -256,6 +257,36 @@
   Value value_;
 };
 
+
+enum Patchability {
+  kPatchable,
+  kNotPatchable,
+};
+
+
+class ObjectPool : public ValueObject {
+ public:
+  ObjectPool() : object_pool_(GrowableObjectArray::Handle()) { }
+
+  intptr_t AddObject(const Object& obj, Patchability patchable);
+  intptr_t AddExternalLabel(const ExternalLabel* label,
+                            Patchability patchable);
+
+  intptr_t FindObject(const Object& obj, Patchability patchable);
+  intptr_t FindExternalLabel(const ExternalLabel* label,
+                             Patchability patchable);
+  const GrowableObjectArray& data() const { return object_pool_; }
+ private:

[Vyacheslav Egorov (Google), 2015/02/06 15:55:18]

new line before private

[Florian Schneider, 2015/02/09 10:25:36]

Done.

+  // Objects and jump targets.
+  GrowableObjectArray& object_pool_;
+
+  // Patchability of pool entries.
+  GrowableArray<Patchability> patchable_pool_entries_;
+
+  // Hashmap for fast lookup in object pool.
+  DirectChainedHashMap<ObjIndexPair> object_pool_index_table_;
+};
+
 }  // namespace dart