Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 885443004: [Extensions] Cache extension action icons (Closed)

Created:
5 years, 11 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rsesek+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Cache extension action icons Cache extension action icons so that they don't have to be reloaded each time a new view is created (i.e., each time a new browser or the new overflow menu is opened). BUG=452958 Committed: https://crrev.com/f19c7663b819419271996f47be3f2be55db95fb7 Cr-Commit-Position: refs/heads/master@{#313724}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -266 lines) Patch
M chrome/browser/extensions/api/system_indicator/system_indicator_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_action.h View 6 chunks +33 lines, -27 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 6 chunks +98 lines, -47 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory.cc View 1 3 chunks +15 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action_manager.cc View 4 chunks +2 lines, -40 lines 0 comments Download
M chrome/browser/extensions/extension_action_unittest.cc View 2 chunks +116 lines, -101 lines 0 comments Download
M extensions/browser/extension_icon_image.h View 1 6 chunks +15 lines, -8 lines 0 comments Download
M extensions/browser/extension_icon_image.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
Please take a look when you can :)
5 years, 10 months ago (2015-01-28 20:57:59 UTC) #4
Finnur
LGTM
5 years, 10 months ago (2015-01-29 09:26:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885443004/60001
5 years, 10 months ago (2015-01-29 16:54:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-01-29 16:58:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 16:59:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f19c7663b819419271996f47be3f2be55db95fb7
Cr-Commit-Position: refs/heads/master@{#313724}

Powered by Google App Engine
This is Rietveld 408576698