[Extensions] Cache extension action icons

chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/system_indicator/system_indicator_manager.h"
 
 #include "base/memory/linked_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 12 matching lines @@
 namespace system_indicator = api::system_indicator;
 
 // Observes clicks on a given status icon and forwards the event to the
 // appropriate extension.  Handles icon updates, and responsible for creating
 // and removing the icon from the notification area during construction and
 // destruction.
 class ExtensionIndicatorIcon : public StatusIconObserver,
                                public ExtensionActionIconFactory::Observer {
  public:
   static ExtensionIndicatorIcon* Create(const Extension* extension,
-                                        const ExtensionAction* action,
+                                        ExtensionAction* action,
                                         Profile* profile,
                                         StatusTray* status_tray);
   ~ExtensionIndicatorIcon() override;
 
   // StatusIconObserver implementation.
   void OnStatusIconClicked() override;
 
   // ExtensionActionIconFactory::Observer implementation.
   void OnIconUpdated() override;
 
  private:
   ExtensionIndicatorIcon(const Extension* extension,
-                         const ExtensionAction* action,
+                         ExtensionAction* action,
                          Profile* profile,
                          StatusTray* status_tray);
 
   const extensions::Extension* extension_;
   StatusTray* status_tray_;
   StatusIcon* icon_;
   Profile* profile_;
   ExtensionActionIconFactory icon_factory_;
 };
 
 ExtensionIndicatorIcon* ExtensionIndicatorIcon::Create(
     const Extension* extension,
-    const ExtensionAction* action,
+    ExtensionAction* action,
     Profile* profile,
     StatusTray* status_tray) {
   scoped_ptr<ExtensionIndicatorIcon> extension_icon(
       new ExtensionIndicatorIcon(extension, action, profile, status_tray));
 
   // Check if a status icon was successfully created.
   if (extension_icon->icon_)
     return extension_icon.release();
 
   // We could not create a status icon.
@@ skipping 19 matching lines @@
   event_router->DispatchEventToExtension(
       extension_->id(), event.Pass());
 }
 
 void ExtensionIndicatorIcon::OnIconUpdated() {
   icon_->SetImage(
       icon_factory_.GetIcon(ExtensionAction::kDefaultTabId).AsImageSkia());
 }
 
 ExtensionIndicatorIcon::ExtensionIndicatorIcon(const Extension* extension,
-                                               const ExtensionAction* action,
+                                               ExtensionAction* action,
                                                Profile* profile,
                                                StatusTray* status_tray)
     : extension_(extension),
       status_tray_(status_tray),
       icon_(NULL),
       profile_(profile),
       icon_factory_(profile, extension, action, this) {
   // Get the icon image and tool tip for the status icon. The extension name is
   // used as the tool tip.
   gfx::ImageSkia icon_image =
@@ skipping 59 matching lines @@
 
     if (it == system_indicators_.end())
       return false;
 
     it->second->OnStatusIconClicked();
     return true;
 }
 
 void SystemIndicatorManager::CreateOrUpdateIndicator(
     const Extension* extension,
-    const ExtensionAction* extension_action) {
+    ExtensionAction* extension_action) {
   DCHECK(thread_checker_.CalledOnValidThread());
   SystemIndicatorMap::iterator it = system_indicators_.find(extension->id());
   if (it != system_indicators_.end()) {
     it->second->OnIconUpdated();
     return;
   }
 
   ExtensionIndicatorIcon* extension_icon = ExtensionIndicatorIcon::Create(
       extension, extension_action, profile_, status_tray_);
   if (extension_icon)
     system_indicators_[extension->id()] = make_linked_ptr(extension_icon);
 }
 
 void SystemIndicatorManager::RemoveIndicator(const std::string& extension_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
   system_indicators_.erase(extension_id);
 }
 
 }  // namespace extensions