chrome/browser/extensions/extension_action_icon_factory_unittest.cc - Issue 885443004: [Extensions] Cache extension action icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

Issue 885443004: [Extensions] Cache extension action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory.cc ('k') | chrome/browser/extensions/extension_action_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

diff --git a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

index 1d56b5f275b9d466c95fdfdd13780a60bc15ef8e..eb7d338575ed2b02cf20c8bd761b7509f1b4b914 100644

--- a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

+++ b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

@@ -263,7 +263,7 @@ TEST_F(ExtensionActionIconFactoryTest, DefaultIcon) {

scoped_ptr<ExtensionIconSet> default_icon_set(new ExtensionIconSet());

default_icon_set->Add(19, "icon.png");

- browser_action->set_default_icon(default_icon_set.Pass());

+ browser_action->SetDefaultIconForTest(default_icon_set.Pass());

ASSERT_TRUE(browser_action->default_icon());

ExtensionActionIconFactory icon_factory(