[Extensions] Cache extension action icons

chrome/browser/extensions/extension_action.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_ACTION_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_ACTION_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
-#include "base/basictypes.h"
-#include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/memory/scoped_vector.h"
-#include "base/memory/weak_ptr.h"
-#include "base/observer_list.h"
+#include "base/stl_util.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
-#include "extensions/common/extension_icon_set.h"
 #include "third_party/skia/include/core/SkColor.h"
-// TODO(robertphillips): change this to "class SkBaseDevice;"
-#include "third_party/skia/include/core/SkDevice.h"
-#include "ui/gfx/animation/linear_animation.h"
 
 class GURL;
-class SkBitmap;
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+class Extension;
+class IconImage;
+}
 
 namespace gfx {
 class Canvas;
 class Image;
 class ImageSkia;
 class Rect;
 class Size;
 }
 
 // ExtensionAction encapsulates the state of a browser action or page action.
 // Instances can have both global and per-tab state. If a property does not have
 // a per-tab value, the global value is used instead.
 class ExtensionAction {
  public:
   // The action that the UI should take after the ExtensionAction is clicked.
   enum ShowAction {
     ACTION_NONE,
     ACTION_SHOW_POPUP,
     // We don't need a SHOW_CONTEXT_MENU because that's handled separately in
     // the UI.
   };
 
   // Use this ID to indicate the default state for properties that take a tab_id
   // parameter.
   static const int kDefaultTabId;
 
   // Max size (both dimensions) for page actions.
   static const int kPageActionIconMaxSize;
 
-  ExtensionAction(const std::string& extension_id,
+  ExtensionAction(const extensions::Extension& extension,
                   extensions::ActionInfo::Type action_type,
                   const extensions::ActionInfo& manifest_data);
   ~ExtensionAction();
 
-  // Gets a copy of this, ownership passed to caller.
-  // It doesn't make sense to copy of an ExtensionAction except in tests.
-  scoped_ptr<ExtensionAction> CopyForTest() const;
-
-  // Given the extension action type, returns the size the extension action icon
-  // should have. The icon should be square, so only one dimension is
-  // returned.
-  static int GetIconSizeForType(extensions::ActionInfo::Type type);
-
   // extension id
   const std::string& extension_id() const { return extension_id_; }
 
   // What kind of action is this?
   extensions::ActionInfo::Type action_type() const {
     return action_type_;
   }
 
   // action id -- only used with legacy page actions API
   std::string id() const { return id_; }
@@ skipping 34 matching lines @@
 
   // Gets the icon that has been set using |SetIcon| for the tab.
   gfx::ImageSkia GetExplicitlySetIcon(int tab_id) const;
 
   // Sets the icon for a tab, in a way that can't be read by the extension's
   // javascript.  Multiple icons can be set at the same time; some icon with the
   // highest priority will be used.
   void DeclarativeSetIcon(int tab_id, int priority, const gfx::Image& icon);
   void UndoDeclarativeSetIcon(int tab_id, int priority, const gfx::Image& icon);
 
-  // Non-tab-specific icon path. This is used to support the default_icon key of
-  // page and browser actions.
-  void set_default_icon(scoped_ptr<ExtensionIconSet> icon_set) {
-     default_icon_ = icon_set.Pass();
-  }
-
   const ExtensionIconSet* default_icon() const {
     return default_icon_.get();
   }
 
   // Set this action's badge text on a specific tab.
   void SetBadgeText(int tab_id, const std::string& text) {
     SetValue(&badge_text_, tab_id, text);
   }
   // Get the badge text for a tab, or the default if no badge text was set.
   std::string GetBadgeText(int tab_id) const {
@@ skipping 55 matching lines @@
   void ClearAllValuesForTab(int tab_id);
 
   // If the specified tab has a badge, paint it into the provided bounds.
   void PaintBadge(gfx::Canvas* canvas, const gfx::Rect& bounds, int tab_id);
 
   // Returns icon image with badge for specified tab.
   gfx::ImageSkia GetIconWithBadge(const gfx::ImageSkia& icon,
                                   int tab_id,
                                   const gfx::Size& spacing) const;
 
+  // Lazily loads and returns the default icon image, if one exists for the
+  // action.
+  extensions::IconImage* LoadDefaultIconImage(
+      const extensions::Extension& extension,
+      content::BrowserContext* browser_context);
+
+  // Returns the image to use as the default icon for the action. Can only be
+  // called after LoadDefaultIconImage().
+  gfx::ImageSkia GetDefaultIconImage() const;
+
   // Determine whether or not the ExtensionAction has a value set for the given
   // |tab_id| for each property.
   bool HasPopupUrl(int tab_id) const;
   bool HasTitle(int tab_id) const;
   bool HasBadgeText(int tab_id) const;
   bool HasBadgeBackgroundColor(int tab_id) const;
   bool HasBadgeTextColor(int tab_id) const;
   bool HasIsVisible(int tab_id) const;
   bool HasIcon(int tab_id) const;
 
+  void SetDefaultIconForTest(scoped_ptr<ExtensionIconSet> default_icon);
+
  private:
+  // Populates the action from the |extension| and |manifest_data|, filling in
+  // any missing values (like title or icons) as possible.
+  void Populate(const extensions::Extension& extension,
+                const extensions::ActionInfo& manifest_data);
+
   // Returns width of the current icon for tab_id.
   // TODO(tbarzic): The icon selection is done in ExtensionActionIconFactory.
   // We should probably move this there too.
   int GetIconWidth(int tab_id) const;
 
   template <class T>
   struct ValueTraits {
     static T CreateEmpty() {
       return T();
     }
@@ skipping 51 matching lines @@
   // Maps tab_id to the number of active (applied-but-not-reverted)
   // declarativeContent.ShowPageAction actions.
   std::map<int, int> declarative_show_count_;
 
   // declarative_icon_[tab_id][declarative_rule_priority] is a vector of icon
   // images that are currently in effect
   std::map<int, std::map<int, std::vector<gfx::Image> > > declarative_icon_;
 
   // ExtensionIconSet containing paths to bitmaps from which default icon's
   // image representations will be selected.
-  scoped_ptr<const ExtensionIconSet> default_icon_;
+  scoped_ptr<ExtensionIconSet> default_icon_;
+
+  // The default icon image, if |default_icon_| exists.
+  // Lazily initialized via LoadDefaultIconImage().
+  scoped_ptr<extensions::IconImage> default_icon_image_;
 
   // The id for the ExtensionAction, for example: "RssPageAction". This is
   // needed for compat with an older version of the page actions API.
   std::string id_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionAction);
 };
 
 template<>
 struct ExtensionAction::ValueTraits<int> {
   static int CreateEmpty() {
     return -1;
   }
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_ACTION_H_