chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc - Issue 885443004: [Extensions] Cache extension action icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

Issue 885443004: [Extensions] Cache extension action icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_indicator/system_indicator_manager.h ('k') | chrome/browser/extensions/extension_action.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

index f358a95b90bd2e9168a4ef4ad5428cb26ccf3b97..3f5186acafa3f6f5ac0e462085ed74418add8db6 100644

--- a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

+++ b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

@@ -30,7 +30,7 @@ class ExtensionIndicatorIcon : public StatusIconObserver,

public ExtensionActionIconFactory::Observer {

public:

static ExtensionIndicatorIcon* Create(const Extension* extension,

- const ExtensionAction* action,

+ ExtensionAction* action,

Profile* profile,

StatusTray* status_tray);

~ExtensionIndicatorIcon() override;

@@ -43,7 +43,7 @@ class ExtensionIndicatorIcon : public StatusIconObserver,

private:

ExtensionIndicatorIcon(const Extension* extension,

- const ExtensionAction* action,

+ ExtensionAction* action,

Profile* profile,

StatusTray* status_tray);

@@ -56,7 +56,7 @@ class ExtensionIndicatorIcon : public StatusIconObserver,

ExtensionIndicatorIcon* ExtensionIndicatorIcon::Create(

const Extension* extension,

- const ExtensionAction* action,

+ ExtensionAction* action,

Profile* profile,

StatusTray* status_tray) {

scoped_ptr<ExtensionIndicatorIcon> extension_icon(

@@ -96,7 +96,7 @@ void ExtensionIndicatorIcon::OnIconUpdated() {

}

ExtensionIndicatorIcon::ExtensionIndicatorIcon(const Extension* extension,

- const ExtensionAction* action,

+ ExtensionAction* action,

Profile* profile,

StatusTray* status_tray)

: extension_(extension),

@@ -176,7 +176,7 @@ bool SystemIndicatorManager::SendClickEventToExtensionForTest(

void SystemIndicatorManager::CreateOrUpdateIndicator(

const Extension* extension,

- const ExtensionAction* extension_action) {

+ ExtensionAction* extension_action) {

DCHECK(thread_checker_.CalledOnValidThread());

SystemIndicatorMap::iterator it = system_indicators_.find(extension->id());

if (it != system_indicators_.end()) {