Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, asanka, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, tzik, shishir+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, dzhioev+watch_chromium.org, jam, Patrick Dubroy, rlp+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, nhiroki, feature-media-reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, tfarina, darin-cc_chromium.org, estade+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webui: add [lang] attribute to <html> element on all webui pages so screen readers know which human language to read a page in. R=dmazzoni@chromium.org TBR=sky@chromium.org,asanka@chromium.org BUG=438704 Committed: https://crrev.com/622e9f3ea07679047bc6884b0ed67fbd2cc317f6 Cr-Commit-Position: refs/heads/master@{#313584}

Patch Set 1 #

Total comments: 6

Patch Set 2 : dmazzoni@ review #

Patch Set 3 : merge #

Patch Set 4 : whoops #

Patch Set 5 : more fixes #

Patch Set 6 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -138 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/interstitials/security_interstitial_page.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/about_conflicts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_flash.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_nacl.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_sys/about_sys.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_voicesearch.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/app_list/start_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/certificate_viewer.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/bluetooth_pair_device.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/certificate_manager_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/choose_mobile_network.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/device_log_ui/device_log_ui.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/first_run/app/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/guest_session_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/merge_session_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/nfc_debug.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_app_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_net_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/set_time.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/sim_unlock.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/slow.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/components.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/copresence.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/crashes.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/domain_reliability_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/downloads/downloads.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/html/default.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/flags.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gcm_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/help/help.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/history/history.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword_audio_verification/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/identity_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/inline_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/new_inline_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media/webrtc_logs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/guest_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/incognito_tab.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/password_manager_internals/password_manager_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/index.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/index-material.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugins.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/policy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/predictors/predictors.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/profile_signin_confirmation.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/quota_internals/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/set_as_default_browser.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/signin_internals/signin_index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/supervised_user_block_interstitial.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_file_system_internals/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/user_manager/user_manager.html View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 5 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/system_info_ui.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/localized_error.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/localized_error.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/resources/error_app.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/neterror.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/gpu/gpu_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/indexed_db/indexeddb_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/media_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/webrtc_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/service_worker/serviceworker_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/base/dir_header.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/webui/web_ui_util.h View 1 2 3 1 chunk +5 lines, -7 lines 0 comments Download
M ui/base/webui/web_ui_util.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
Dan Beam
5 years, 10 months ago (2015-01-28 17:06:51 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/880313002/diff/1/chrome/browser/resources/about_voicesearch.html File chrome/browser/resources/about_voicesearch.html (right): https://codereview.chromium.org/880313002/diff/1/chrome/browser/resources/about_voicesearch.html#newcode2 chrome/browser/resources/about_voicesearch.html:2: <html i18n-values="dir:textdirection;lang:language"> q: is it better style to ...
5 years, 10 months ago (2015-01-28 17:20:54 UTC) #2
Dan Beam
https://codereview.chromium.org/880313002/diff/1/chrome/browser/resources/about_voicesearch.html File chrome/browser/resources/about_voicesearch.html (right): https://codereview.chromium.org/880313002/diff/1/chrome/browser/resources/about_voicesearch.html#newcode2 chrome/browser/resources/about_voicesearch.html:2: <html i18n-values="dir:textdirection;lang:language"> On 2015/01/28 17:20:54, dmazzoni wrote: > q: ...
5 years, 10 months ago (2015-01-28 17:48:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880313002/20001
5 years, 10 months ago (2015-01-28 17:49:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/52746)
5 years, 10 months ago (2015-01-28 17:53:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880313002/40001
5 years, 10 months ago (2015-01-28 18:28:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880313002/60001
5 years, 10 months ago (2015-01-28 18:34:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38945)
5 years, 10 months ago (2015-01-28 18:42:54 UTC) #14
Dan Beam
TBR=sky for chrome/, ui/ TBR=asanka for net/
5 years, 10 months ago (2015-01-28 18:51:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880313002/80001
5 years, 10 months ago (2015-01-28 19:13:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/2740)
5 years, 10 months ago (2015-01-28 19:31:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880313002/100001
5 years, 10 months ago (2015-01-28 20:06:05 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-01-28 21:23:19 UTC) #22
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:25:02 UTC) #23
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/622e9f3ea07679047bc6884b0ed67fbd2cc317f6
Cr-Commit-Position: refs/heads/master@{#313584}

Powered by Google App Engine
This is Rietveld 408576698