chrome/browser/ui/webui/system_info_ui.cc - Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/system_info_ui.cc

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cros Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/system_info_ui.cc

diff --git a/chrome/browser/ui/webui/system_info_ui.cc b/chrome/browser/ui/webui/system_info_ui.cc

index dc348132701613c564062e6230069746b10b4e65..cb840cb5d821b28e1f2a68afbad2f0dc6e42f886 100644

--- a/chrome/browser/ui/webui/system_info_ui.cc

+++ b/chrome/browser/ui/webui/system_info_ui.cc

@@ -17,6 +17,7 @@

#include "base/threading/thread.h"

#include "base/time/time.h"

#include "base/values.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/feedback/system_logs/about_system_logs_fetcher.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/chrome_paths.h"

@@ -139,7 +140,10 @@ void SystemInfoUIHTMLSource::RequestComplete() {

l10n_util::GetStringUTF16(IDS_ABOUT_SYS_COLLAPSE));

strings.SetString("parseError",

l10n_util::GetStringUTF16(IDS_ABOUT_SYS_PARSE_ERROR));

- webui::SetFontAndTextDirection(&strings);

+ const std::string& app_locale = g_browser_process->GetApplicationLocale();

+ webui::SetLoadTimeDataDefaults(app_locale, &strings);

if (response_.get()) {

base::ListValue* details = new base::ListValue();

strings.Set("details", details);

« no previous file with comments | « chrome/browser/ui/webui/signin/user_manager_ui.cc ('k') | chrome/common/localized_error.h » ('j') | no next file with comments »