chrome/browser/resources/about_voicesearch.html - Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/about_voicesearch.html

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | chrome/browser/resources/app_list/start_page.html » ('j') | chrome/browser/resources/chromeos/first_run/first_run.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;">	2 <html i18n-values="dir:textdirection;lang:language">
	dmazzoni 2015/01/28 17:20:54 q: is it better style to end each in a semicolon o q: is it better style to end each in a semicolon or to separate with semicolons? it looks like previously a few of these ended with a semicolon, maybe redundantly Dan Beam 2015/01/28 17:48:27 yeah, I just felt like this might be wasted space Show quoted text On 2015/01/28 17:20:54, dmazzoni wrote: > q: is it better style to end each in a semicolon or to separate with semicolons? > > it looks like previously a few of these ended with a semicolon, maybe > redundantly yeah, I just felt like this might be wasted space
3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

6 <style>	6 <style>

7 .key {	7 .key {

8 font-weight: bold;	8 font-weight: bold;

9 }	9 }

10	10

11 .value {	11 .value {

12 margin-left: 15px;	12 margin-left: 15px;

(...skipping 16 matching lines...) Expand all Loading...
29 </div>	29 </div>

30 </div>	30 </div>

31 <script src="chrome://resources/js/load_time_data.js"></script>	31 <script src="chrome://resources/js/load_time_data.js"></script>

32 <script src="chrome://voicesearch/about_voicesearch.js"></script>	32 <script src="chrome://voicesearch/about_voicesearch.js"></script>

33 <script src="chrome://voicesearch/strings.js"></script>	33 <script src="chrome://voicesearch/strings.js"></script>

34 <script src="chrome://resources/js/i18n_template2.js"></script>	34 <script src="chrome://resources/js/i18n_template2.js"></script>

35 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	35 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

36 <script src="chrome://resources/js/util.js"></script>	36 <script src="chrome://resources/js/util.js"></script>

37 </body>	37 </body>

38 </html>	38 </html>

OLD	NEW