chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc - Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cros Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | chrome/browser/extensions/api/feedback_private/feedback_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

index 63f40e7be4c04cf0064ad81725ecabec5629dcc1..d2dd757493e481029e8cd918eaa7413c268f8001 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/bookmark_stats.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h"

#include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h"

#include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h"

@@ -518,7 +519,8 @@ bool BookmarkManagerPrivateGetStringsFunction::RunAsync() {

localized_strings->SetString("cancel",

l10n_util::GetStringUTF16(IDS_CANCEL));

- webui::SetFontAndTextDirection(localized_strings);

+ const std::string& app_locale = g_browser_process->GetApplicationLocale();

+ webui::SetLoadTimeDataDefaults(app_locale, localized_strings);

SetResult(localized_strings);