ui/base/webui/web_ui_util.h - Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/webui/web_ui_util.h

Issue 880313002: webui: add [lang] attribute to <html> element on all webui pages so (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cros Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/webui/web_ui_util.h

diff --git a/ui/base/webui/web_ui_util.h b/ui/base/webui/web_ui_util.h

index 2dbcfc72e008376f87470ebe63143a70677a7213..34596408ff2833f727d8b5a8e4e016fdfa52a0b1 100644

--- a/ui/base/webui/web_ui_util.h

+++ b/ui/base/webui/web_ui_util.h

@@ -45,13 +45,11 @@ UI_BASE_EXPORT void ParsePathAndScale(const GURL& url,

std::string* path,

float* scale_factor);

-// Helper function to set the font family, size, and text direction into the

-// given dictionary.

-// Note that using font family and size in JS templates is deprecated, because

-// it might lead to flicker. Instead, use AppendWebUICSSTextDefaults() below.

-// TODO(bauerb): Remove uses of font-family and font-size in JS templates, then

-// rename this method to SetTextDirection().

-UI_BASE_EXPORT void SetFontAndTextDirection(

+// Helper function to set some default values (e.g., font family, size,

+// language, and text direction) into the given dictionary. Requires an

+// application locale (i.e. g_browser_process->GetApplicationLocale()).

+UI_BASE_EXPORT void SetLoadTimeDataDefaults(

+ const std::string& app_locale,

base::DictionaryValue* localized_strings);

// Get a CSS declaration for common text styles for all of Web UI.

« no previous file with comments | « net/base/dir_header.html ('k') | ui/base/webui/web_ui_util.cc » ('j') | no next file with comments »