Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 872043003: module.exports should default to an empty object. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

module.exports should default to an empty object. Per the spec in modules.md the exports property should default to an empty object. We lazy allocate it so that modules that just replace it don't create the empty object and then throw it away. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/670cc46fb1c30d9450ec5f61963ab92c659d3c43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M sky/engine/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptValue.h View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/engine/bindings/templates/attributes.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/core/app/AbstractModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/app/Module.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/app/Module.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M sky/engine/core/app/Module.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/city-list/city-list.sky View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/tests/modules/import-without-export.sky View 1 chunk +4 lines, -2 lines 0 comments Download
M sky/tests/modules/modules.sky View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/tests/modules/modules-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-24 01:13:22 UTC) #2
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-24 05:13:15 UTC) #3
esprehn
5 years, 11 months ago (2015-01-26 19:38:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
670cc46fb1c30d9450ec5f61963ab92c659d3c43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698