sky/engine/bindings/core/v8/ScriptValue.h - Issue 872043003: module.exports should default to an empty object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/ScriptValue.h

Issue 872043003: module.exports should default to an empty object. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/ScriptValue.h

diff --git a/sky/engine/bindings/core/v8/ScriptValue.h b/sky/engine/bindings/core/v8/ScriptValue.h

index 9102432ada395b4082bbe5861e5c49b9a791802a..41996d4d753c8c24daff0eb1a236a6b84908efa6 100644

--- a/sky/engine/bindings/core/v8/ScriptValue.h

+++ b/sky/engine/bindings/core/v8/ScriptValue.h

@@ -60,6 +60,11 @@ public:

ASSERT(isEmpty() || m_scriptState);

}

+ static ScriptValue createEmptyObject(ScriptState* scriptState)

+ {

+ return ScriptValue(scriptState, v8::Object::New(scriptState->isolate()));

+ }

ScriptState* scriptState() const

{

return m_scriptState.get();