Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: sky/engine/bindings/core/v8/ScriptController.cpp

Issue 872043003: module.exports should default to an empty object. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptController.cpp
diff --git a/sky/engine/bindings/core/v8/ScriptController.cpp b/sky/engine/bindings/core/v8/ScriptController.cpp
index bd14d09324be2c154b35cdc279e022a54c84a61c..ffc6aeefd5ce3126a21b1115d27ab5d1f4266c15 100644
--- a/sky/engine/bindings/core/v8/ScriptController.cpp
+++ b/sky/engine/bindings/core/v8/ScriptController.cpp
@@ -295,7 +295,7 @@ void ScriptController::executeModuleScript(AbstractModule& module, const String&
scriptModule.formalDependencies.append(name);
v8::Handle<v8::Value> actual;
if (Module* childModule = child->module())
- actual = childModule->exports().v8Value();
+ actual = childModule->exports(scriptState).v8Value();
if (actual.IsEmpty())
actual = v8::Undefined(m_isolate);
scriptModule.resolvedDependencies.append(actual);
« no previous file with comments | « no previous file | sky/engine/bindings/core/v8/ScriptValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698