Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: sky/engine/core/app/Module.h

Issue 872043003: module.exports should default to an empty object. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/app/AbstractModule.cpp ('k') | sky/engine/core/app/Module.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/app/Module.h
diff --git a/sky/engine/core/app/Module.h b/sky/engine/core/app/Module.h
index 29ff7c5ef8b70bdc9fa514df65cfa5529b04a6a6..525b62734f9b2317118509768782d70c2685330e 100644
--- a/sky/engine/core/app/Module.h
+++ b/sky/engine/core/app/Module.h
@@ -24,8 +24,8 @@ public:
Application* application() const { return application_.get(); }
- void setExports(const ScriptValue& exports) { exports_ = exports; }
- const ScriptValue& exports() const { return exports_; }
+ void setExports(ScriptState*, const ScriptValue& exports);
+ const ScriptValue& exports(ScriptState*) const;
private:
Module(ExecutionContext* context,
@@ -37,7 +37,7 @@ private:
Application* GetApplication() override;
RefPtr<Application> application_;
- ScriptValue exports_;
+ mutable ScriptValue exports_;
};
} // namespace blink
« no previous file with comments | « sky/engine/core/app/AbstractModule.cpp ('k') | sky/engine/core/app/Module.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698