sky/engine/core/app/AbstractModule.cpp - Issue 872043003: module.exports should default to an empty object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/app/AbstractModule.cpp

Issue 872043003: module.exports should default to an empty object. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/app/AbstractModule.cpp

diff --git a/sky/engine/core/app/AbstractModule.cpp b/sky/engine/core/app/AbstractModule.cpp

index a505f15e3cf5eec738dc45cb35cbbfc7d4447266..fccb59bf2216a456a4b555a5018f6ad3b664d239 100644

--- a/sky/engine/core/app/AbstractModule.cpp

+++ b/sky/engine/core/app/AbstractModule.cpp

@@ -41,7 +41,7 @@ void AbstractModule::OnModuleLoadComplete(ModuleLoader* loader,

Module* module) {

RefPtr<ScriptPromiseResolver> resolver = loaders_.take(loader);

ScriptState::Scope scope(resolver->scriptState());

- resolver->resolve(module->exports().v8Value());

+ resolver->resolve(module->exports(resolver->scriptState()).v8Value());

}

} // namespace blink

« no previous file with comments | « sky/engine/bindings/templates/attributes.cpp ('k') | sky/engine/core/app/Module.h » ('j') | no next file with comments »