[Extensions Toolbar] Move some popup logic to be platform-agnostic

[Extensions Toolbar] Move some popup logic to be platform-agnostic

Move the "is popup showing" logic to the platform-agnostic
ExtensionActionViewController. This lets us:
- Have a slimmer platform delegate.
- Implement OnPopupShown/Closed pressed-state logic on mac.
- Add cross-platform popup browsertests.

BUG=429810
BUG=422381
TBR=sky@chromium.org (micro changes to page_action_image_view)

Committed: https://crrev.com/b43d48e04f780c3bdb8ff99e9bcd02ca5bb7ce58
Cr-Commit-Position: refs/heads/master@{#313731}

[Devlin, 2015-01-29 01:13:12]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org, finnur@chromium.org

[Devlin, 2015-01-29 01:13:12]

When you have time :)
Avi - Cocoa
Finnur - Everything else

[Avi (use Gerrit), 2015-01-29 02:59:27]

LGTM with nitty nits

https://codereview.chromium.org/869873008/diff/1/chrome/browser/ui/cocoa/exte...
File chrome/browser/ui/cocoa/extensions/browser_action_button.mm (right):

https://codereview.chromium.org/869873008/diff/1/chrome/browser/ui/cocoa/exte...
chrome/browser/ui/cocoa/extensions/browser_action_button.mm:41: @interface
BrowserActionButton (Private)
You can use a class extension by dropping the contents of the ().

https://codereview.chromium.org/869873008/diff/1/chrome/browser/ui/extensions...
File chrome/browser/ui/extensions/extension_action_view_controller.cc (right):

https://codereview.chromium.org/869873008/diff/1/chrome/browser/ui/extensions...
chrome/browser/ui/extensions/extension_action_view_controller.cc:239: //
TODO(devlin): Ew. Notifications. Extract out an observer interface for
Ew! That's the spirit!

[Finnur, 2015-01-29 10:02:16]

LGTM

[Devlin, 2015-01-29 17:03:42]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-01-29 17:04:34]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org

[Devlin, 2015-01-29 17:42:08]

https://codereview.chromium.org/869873008/diff/1/chrome/browser/ui/cocoa/exte...
File chrome/browser/ui/cocoa/extensions/browser_action_button.mm (right):

https://codereview.chromium.org/869873008/diff/1/chrome/browser/ui/cocoa/exte...
chrome/browser/ui/cocoa/extensions/browser_action_button.mm:41: @interface
BrowserActionButton (Private)
On 2015/01/29 02:59:26, Avi wrote:
> You can use a class extension by dropping the contents of the ().

Ooh, class extensions vs categories.  Nifty.

Thanks for the tip, and done. :)

[Devlin, 2015-01-29 17:42:18]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-01-29 17:43:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869873008/40001

[commit-bot: I haz the power, 2015-01-29 17:52:10]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-29 17:53:14]

Patchset 2 (id:??) landed as
https://crrev.com/b43d48e04f780c3bdb8ff99e9bcd02ca5bb7ce58
Cr-Commit-Position: refs/heads/master@{#313731}