Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4914)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h

Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avi's Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h b/chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h
index af8cc6f1370642169fb890c7542dc8c7e249a9a5..3c3000fe05606073378ea8b6e57a5eff529f59ef 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h
@@ -37,16 +37,6 @@ class ToolbarActionViewDelegateViews : public ToolbarActionViewDelegate {
// allows views code to update the pressed state of the button).
virtual views::MenuButton* GetContextMenuButton() = 0;
- // Hides whatever popup is active (even if it's not this one).
- virtual void HideActivePopup() = 0;
-
- // Called when a popup is shown. See ExecuteAction() for the definition of
- // |grant_tab_permissions|.
- virtual void OnPopupShown(bool grant_tab_permissions) {}
-
- // Does any additional cleanup after the popup is closed.
- virtual void CleanupPopup() {}
-
protected:
~ToolbarActionViewDelegateViews() override {}
};
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698