Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avi's Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VI EWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VI EWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VI EWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VI EWS_H_
7 7
8 #include "chrome/browser/ui/extensions/extension_action_platform_delegate.h" 8 #include "chrome/browser/ui/extensions/extension_action_platform_delegate.h"
9 #include "chrome/browser/ui/views/extensions/extension_popup.h" 9 #include "chrome/browser/ui/views/extensions/extension_popup.h"
10 #include "content/public/browser/notification_observer.h" 10 #include "content/public/browser/notification_observer.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 ExtensionActionPlatformDelegateViews( 54 ExtensionActionPlatformDelegateViews(
55 ExtensionActionViewController* controller); 55 ExtensionActionViewController* controller);
56 ~ExtensionActionPlatformDelegateViews() override; 56 ~ExtensionActionPlatformDelegateViews() override;
57 57
58 private: 58 private:
59 // ExtensionActionPlatformDelegate: 59 // ExtensionActionPlatformDelegate:
60 gfx::NativeView GetPopupNativeView() override; 60 gfx::NativeView GetPopupNativeView() override;
61 bool IsMenuRunning() const override; 61 bool IsMenuRunning() const override;
62 void RegisterCommand() override; 62 void RegisterCommand() override;
63 void OnDelegateSet() override; 63 void OnDelegateSet() override;
64 bool IsShowingPopup() const override;
65 void CloseActivePopup() override; 64 void CloseActivePopup() override;
66 void CloseOwnPopup() override; 65 void CloseOwnPopup() override;
67 bool ShowPopupWithUrl( 66 extensions::ExtensionViewHost* ShowPopupWithUrl(
68 ExtensionActionViewController::PopupShowAction show_action, 67 ExtensionActionViewController::PopupShowAction show_action,
69 const GURL& popup_url, 68 const GURL& popup_url,
70 bool grant_tab_permissions) override; 69 bool grant_tab_permissions) override;
71 70
72 // content::NotificationObserver: 71 // content::NotificationObserver:
73 void Observe(int type, 72 void Observe(int type,
74 const content::NotificationSource& source, 73 const content::NotificationSource& source,
75 const content::NotificationDetails& details) override; 74 const content::NotificationDetails& details) override;
76 75
77 // ui::AcceleratorTarget: 76 // ui::AcceleratorTarget:
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 base::Closure followup_context_menu_task_; 124 base::Closure followup_context_menu_task_;
126 125
127 content::NotificationRegistrar registrar_; 126 content::NotificationRegistrar registrar_;
128 127
129 base::WeakPtrFactory<ExtensionActionPlatformDelegateViews> weak_factory_; 128 base::WeakPtrFactory<ExtensionActionPlatformDelegateViews> weak_factory_;
130 129
131 DISALLOW_COPY_AND_ASSIGN(ExtensionActionPlatformDelegateViews); 130 DISALLOW_COPY_AND_ASSIGN(ExtensionActionPlatformDelegateViews);
132 }; 131 };
133 132
134 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE _VIEWS_H_ 133 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE _VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698