chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h - Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avi's Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

index 424fe79bb5c8d4d0e878f1fb7dacdc42c5425809..ba58ebead4bd8673bd0f10b25adfa12c362a4521 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

@@ -28,10 +28,9 @@ class ExtensionActionPlatformDelegateCocoa

bool IsMenuRunning() const override;

void RegisterCommand() override;

void OnDelegateSet() override;

- bool IsShowingPopup() const override;

void CloseActivePopup() override;

void CloseOwnPopup() override;

- bool ShowPopupWithUrl(

+ extensions::ExtensionViewHost* ShowPopupWithUrl(

ExtensionActionViewController::PopupShowAction show_action,

const GURL& popup_url,

bool grant_tab_permissions) override;