Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/ui/toolbar/toolbar_action_view_delegate.h

Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avi's Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_action_view_delegate.h
diff --git a/chrome/browser/ui/toolbar/toolbar_action_view_delegate.h b/chrome/browser/ui/toolbar/toolbar_action_view_delegate.h
index 748e25bd9a0d842c0141a77fbe402f7a583d4327..7c7c4d196ff118efb516981fe7e7c36847b51968 100644
--- a/chrome/browser/ui/toolbar/toolbar_action_view_delegate.h
+++ b/chrome/browser/ui/toolbar/toolbar_action_view_delegate.h
@@ -26,6 +26,13 @@ class ToolbarActionViewDelegate {
// Updates the view to reflect current state.
virtual void UpdateState() = 0;
+ // Called when a popup is shown. If |by_user| is true, then this was through
+ // a direct user action (as oppposed to, e.g., an API call).
+ virtual void OnPopupShown(bool by_user) {}
+
+ // Called when a popup is closed.
+ virtual void OnPopupClosed() {}
+
protected:
virtual ~ToolbarActionViewDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698