Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 868043003: [PATCH 8/11] ozone: evdev: Plumb device changes to EventFactoryEvdev (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Plumb device changes to EventFactoryEvdev This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. We must access DeviceDataManager from the UI thread only, so send a new list to EventFactoryEvdev when devices are added or removed, and update DeviceDataManager from there. InputControllerEvdev also needs to know if there's a mouse or touchpad attached, so additionally plumb lists for those devices and update this property on InputControllerEvdev. BUG=449710 TEST=boot link_freon & move mouse Committed: https://crrev.com/c77b18bf9bee62805a9ed5d1ae12e2f0c6944f45 Cr-Commit-Position: refs/heads/master@{#313865}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -43 lines) Patch
M ui/events/ozone/evdev/device_event_dispatcher_evdev.h View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_device_info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_device_info.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.cc View 1 2 3 2 chunks +13 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 1 2 3 7 chunks +32 lines, -29 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
5 years, 11 months ago (2015-01-23 22:00:48 UTC) #2
spang
5 years, 11 months ago (2015-01-27 19:34:26 UTC) #3
alexst (slow to review)
lgtm https://codereview.chromium.org/868043003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right): https://codereview.chromium.org/868043003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h#newcode62 ui/events/ozone/evdev/device_event_dispatcher_evdev.h:62: class DeviceEventDispatcherEvdev { Please add some threading notes. ...
5 years, 10 months ago (2015-01-28 16:16:44 UTC) #4
spang
https://codereview.chromium.org/868043003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right): https://codereview.chromium.org/868043003/diff/20001/ui/events/ozone/evdev/device_event_dispatcher_evdev.h#newcode62 ui/events/ozone/evdev/device_event_dispatcher_evdev.h:62: class DeviceEventDispatcherEvdev { On 2015/01/28 16:16:44, alexst wrote: > ...
5 years, 10 months ago (2015-01-28 19:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868043003/60001
5 years, 10 months ago (2015-01-30 03:01:26 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-30 03:42:46 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 03:43:42 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c77b18bf9bee62805a9ed5d1ae12e2f0c6944f45
Cr-Commit-Position: refs/heads/master@{#313865}

Powered by Google App Engine
This is Rietveld 408576698