Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867963004: remove unused GM flags (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unused GM flags Depends on https://codereview.chromium.org/873753002/ Thumbs up to CLion for refactoring this for me. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1c4029296f518a84ef90095243ba210163a1e1f9

Patch Set 1 #

Patch Set 2 : bench too #

Patch Set 3 : rebase #

Patch Set 4 : guarded flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -623 lines) Patch
M bench/GMBench.cpp View 1 1 chunk +1 line, -16 lines 0 comments Download
M gm/aaclip.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M gm/aarectmodes.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/alphagradients.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/arcofzorro.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/beziereffects.cpp View 3 chunks +0 lines, -15 lines 0 comments Download
M gm/beziers.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/bigtext.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/bitmaprect.cpp View 1 2 3 2 chunks +1 line, -8 lines 0 comments Download
M gm/bitmapscroll.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/bleed.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/blurcircles.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/blurrect.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/blurs.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/circles.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/circularclips.cpp View 2 1 chunk +0 lines, -3 lines 0 comments Download
M gm/clip_strokerect.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/colorfilters.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/colortype.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/colortypexfermode.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/complexclip.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/complexclip2.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M gm/complexclip3.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/conicpaths.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M gm/convexpaths.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/convexpolyclip.cpp View 2 1 chunk +0 lines, -4 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/cubicpaths.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M gm/dashcubics.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/dashing.cpp View 2 5 chunks +0 lines, -13 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/degeneratesegments.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/discard.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 2 3 3 chunks +1 line, -9 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M gm/drrect.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/factory.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/fatpathfill.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/filltypes.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/filltypespersp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/filterbitmap.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M gm/filterindiabox.cpp View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M gm/fontcache.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/fontmgr.cpp View 3 chunks +1 line, -27 lines 0 comments Download
M gm/fontscaler.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/getpostextpath.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/giantbitmap.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M gm/glyph_pos.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/glyph_pos_align.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/gm.h View 2 3 chunks +1 line, -21 lines 0 comments Download
M gm/gradient_matrix.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/gradients.cpp View 4 chunks +0 lines, -12 lines 0 comments Download
M gm/gradients_no_texture.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M gm/gradtext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/hairlines.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/hairmodes.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/hittestpath.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/image.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/imagealphathreshold.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M gm/imageblur.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/imageblur2.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/imagefiltersbase.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/imagemagnifier.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/imageresizetiled.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/inversepaths.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/lcdtext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/lighting.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/linepaths.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/lumafilter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/mixedxfermodes.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/multipicturedraw.cpp View 2 1 chunk +0 lines, -1 line 0 comments Download
M gm/nested.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/nonclosedpaths.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/ovals.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/patch.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/patchgrid.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/patheffects.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/pathfill.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M gm/pathreverse.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/peekpixels.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M gm/pictureimagefilter.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M gm/pictureshader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/pictureshadertile.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/points.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/poly2poly.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/polygons.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/quadpaths.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M gm/rects.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M gm/roundrects.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/rrect.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M gm/samplerstress.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/selftest.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/shadertext.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/shadertext2.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/shadertext3.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/shallowgradient.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M gm/spritebitmap.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/stringart.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/strokefill.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/strokerect.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/strokerects.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/strokes.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M gm/stroketext.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/tallstretchedbitmaps.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/techtalk1.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/testimagefilters.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/texdata.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/textblobshader.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/tiledscaledbitmap.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M gm/tilemodes.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 1 2 3 2 chunks +0 lines, -10 lines 0 comments Download
M gm/variedtext.cpp View 2 1 chunk +0 lines, -5 lines 0 comments Download
M gm/vertices.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/verttext.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/verttext2.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
5 years, 11 months ago (2015-01-23 18:10:08 UTC) #2
bsalomon
after careful review, this lgtm.
5 years, 11 months ago (2015-01-23 18:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867963004/40001
5 years, 11 months ago (2015-01-23 18:35:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2060)
5 years, 11 months ago (2015-01-23 18:54:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867963004/60001
5 years, 11 months ago (2015-01-23 18:58:48 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 19:07:11 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/1c4029296f518a84ef90095243ba210163a1e1f9

Powered by Google App Engine
This is Rietveld 408576698