Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: gm/fontmgr.cpp

Issue 867963004: remove unused GM flags (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: guarded flags Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/fontcache.cpp ('k') | gm/fontscaler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/fontmgr.cpp
diff --git a/gm/fontmgr.cpp b/gm/fontmgr.cpp
index 9d0e3509f19814db00ae0284201cbd34bee60fbe..e89e585fdeca3c32b53343b8a7a5862f5c3b2094 100644
--- a/gm/fontmgr.cpp
+++ b/gm/fontmgr.cpp
@@ -115,16 +115,6 @@ protected:
}
}
- uint32_t onGetFlags() const SK_OVERRIDE {
- // fontdescriptors (and therefore serialization) don't yet understand
- // these new styles, so skip tests that exercise that for now.
-
- // If certain fonts are picked up (e.g. Microsoft Jhenghei 20MB for Regular, 12MB for Bold),
- // the resulting pdf can be ~700MB and crashes Chrome's PDF viewer.
-
- return kSkipPicture_Flag | kSkipPipe_Flag | kSkipPDF_Flag;
- }
-
private:
SkAutoTUnref<SkFontMgr> fFM;
SkString fName;
@@ -214,12 +204,6 @@ protected:
this->iterateFamily(canvas, paint, fset);
}
- uint32_t onGetFlags() const SK_OVERRIDE {
- // fontdescriptors (and therefore serialization) don't yet understand
- // these new styles, so skip tests that exercise that for now.
- return kSkipPicture_Flag | kSkipPipe_Flag;
- }
-
private:
typedef GM INHERITED;
};
@@ -299,17 +283,7 @@ protected:
}
}
}
-
- uint32_t onGetFlags() const SK_OVERRIDE {
- // fontdescriptors (and therefore serialization) don't yet understand
- // these new styles, so skip tests that exercise that for now.
-
- // If certain fonts are picked up (e.g. Microsoft Jhenghei 20MB for Regular, 12MB for Bold),
- // the resulting pdf can be ~700MB and crashes Chrome's PDF viewer.
-
- return kSkipPicture_Flag | kSkipPipe_Flag | kSkipPDF_Flag;
- }
-
+
private:
SkAutoTUnref<SkFontMgr> fFM;
SkString fName;
« no previous file with comments | « gm/fontcache.cpp ('k') | gm/fontscaler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698