Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: gm/gm.h

Issue 867963004: remove unused GM flags (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: guarded flags Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/glyph_pos_align.cpp ('k') | gm/gradient_matrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gm.h
diff --git a/gm/gm.h b/gm/gm.h
index 55820ac61c2d9fe05af4bd0f99bd6e0179e91fc4..b474729366adcb505409c0f76f977308add8b4a2 100644
--- a/gm/gm.h
+++ b/gm/gm.h
@@ -40,22 +40,6 @@ namespace skiagm {
GM();
virtual ~GM();
- enum Flags {
- kSkipPDF_Flag = 1 << 0,
- kSkipPicture_Flag = 1 << 1,
- kSkipPipe_Flag = 1 << 2,
- kSkipPipeCrossProcess_Flag = 1 << 3,
- kSkipTiled_Flag = 1 << 4,
- kSkip565_Flag = 1 << 5,
- kSkipScaledReplay_Flag = 1 << 6,
- kSkipGPU_Flag = 1 << 7,
- kSkipPDFRasterization_Flag = 1 << 8,
-
- kGPUOnly_Flag = 1 << 9,
-
- kNoBBH_Flag = 1 << 11, // May draw wrong using a bounding-box hierarchy
- };
-
enum Mode {
kGM_Mode,
kSample_Mode,
@@ -74,10 +58,6 @@ namespace skiagm {
virtual bool runAsBench() const { return false; }
- uint32_t getFlags() const {
- return this->onGetFlags();
- }
-
SkScalar width() {
return SkIntToScalar(this->getISize().width());
}
@@ -118,7 +98,7 @@ namespace skiagm {
virtual void onDrawBackground(SkCanvas*);
virtual SkISize onISize() = 0;
virtual SkString onShortName() = 0;
- virtual uint32_t onGetFlags() const { return 0; }
+
virtual SkMatrix onGetInitialTransform() const { return SkMatrix::I(); }
private:
« no previous file with comments | « gm/glyph_pos_align.cpp ('k') | gm/gradient_matrix.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698