Remove outline painting on inlines.

Remove outline painting on inlines.

Jagged edge outlines are more complexity than is justified
for the use-cases. We should enable to use-cases like this,
but with a lower-level line-box + custom painting API.

Removes the paintOutline method on RenderInline. Also removed
a number of dead methods that call absoluteRects so we can delete
that method and related code.

R=esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/ef2fc1e961ca8be1b05403077dc0cc332cbad462

[ojan, 2015-01-27 02:14:52]

ojan@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org, esprehn@chromium.org

[ojan, 2015-01-27 02:14:53]

https://codereview.chromium.org/867653005/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderLineBoxList.cpp (left):

https://codereview.chromium.org/867653005/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderLineBoxList.cpp:219: if (info.phase ==
PaintPhaseOutline || info.phase == PaintPhaseSelfOutline || info.phase ==
PaintPhaseChildOutlines) {
This is the part of the patch that actually changes behavior to not paint the
outlines on inlines.

[esprehn, 2015-01-27 02:44:00]

We should probably also make getComputedStyle().outline result in none for
display types that don't support it? I guess that doesn't match the "paint
whatever you want" model, but it does have nicer ergonomics.

lgtm

[ojan, 2015-01-27 02:54:20]

On 2015/01/27 at 02:44:00, esprehn wrote:
> We should probably also make getComputedStyle().outline result in none for
display types that don't support it? I guess that doesn't match the "paint
whatever you want" model, but it does have nicer ergonomics.

I had that thought. I worry that if we try to do that sort of thing with
getComputedStyle, we'll end up with the style adjuster doing an enormous amount
of work. I think we actually should probably move in the other direction of
trying to eliminate style adjuster entirely. getComputedStyle will just be a
faithful representation of what the author input.

I dunno. I'm not sure. On the other hand, there's some computation you'd rather
do once at style recalc time and not on each layout/paint, but if we're going to
have a style recalc adjustment phase after style recalc, I think we should
probably expose it to the platform properly.

[ojan, 2015-01-27 02:58:09]

Committed patchset #1 (id:1) manually as
ef2fc1e961ca8be1b05403077dc0cc332cbad462 (presubmit successful).