sky/engine/core/rendering/RenderText.cpp - Issue 867653005: Remove outline painting on inlines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderText.cpp

Issue 867653005: Remove outline painting on inlines. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderText.cpp

diff --git a/sky/engine/core/rendering/RenderText.cpp b/sky/engine/core/rendering/RenderText.cpp

index 7e672a0f0843bad99bed97264be9fb3fc3a9130a..615a2e9c5f22f45b01003611cf99d22280c78662 100644

--- a/sky/engine/core/rendering/RenderText.cpp

+++ b/sky/engine/core/rendering/RenderText.cpp

@@ -224,12 +224,6 @@ String RenderText::plainText() const

return plainTextBuilder.toString();

}

-void RenderText::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const

- for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox())

- rects.append(enclosingIntRect(FloatRect(accumulatedOffset + box->topLeft(), box->size())));

static FloatRect localQuadForTextBox(InlineTextBox* box, unsigned start, unsigned end, bool useSelectionHeight)

{

unsigned realEnd = std::min(box->end() + 1, end);