Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: sky/engine/core/rendering/PaintInfo.h

Issue 867653005: Remove outline painting on inlines. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/PaintInfo.h
diff --git a/sky/engine/core/rendering/PaintInfo.h b/sky/engine/core/rendering/PaintInfo.h
index f6e4d522ea1f6a1049a34e4451f72d1e2ce8a3a9..ad3dbc1e7f405ce945a55713de7328f59a2c5751 100644
--- a/sky/engine/core/rendering/PaintInfo.h
+++ b/sky/engine/core/rendering/PaintInfo.h
@@ -47,14 +47,12 @@ class RenderObject;
*/
struct PaintInfo {
PaintInfo(GraphicsContext* newContext, const IntRect& newRect, PaintPhase newPhase,
- RenderObject* newPaintingRoot = 0, ListHashSet<RenderInline*>* newOutlineObjects = 0,
- const RenderLayerModelObject* newPaintContainer = 0)
+ RenderObject* newPaintingRoot = 0, const RenderLayerModelObject* newPaintContainer = 0)
: context(newContext)
, rect(newRect)
, phase(newPhase)
, paintingRoot(newPaintingRoot)
, m_paintContainer(newPaintContainer)
- , m_outlineObjects(newOutlineObjects)
{
}
@@ -94,9 +92,6 @@ struct PaintInfo {
static IntRect infiniteRect() { return IntRect(LayoutRect::infiniteRect()); }
const RenderLayerModelObject* paintContainer() const { return m_paintContainer; }
- ListHashSet<RenderInline*>* outlineObjects() { return m_outlineObjects; }
- void setOutlineObjects(ListHashSet<RenderInline*>* objects) { m_outlineObjects = objects; }
-
// FIXME: Introduce setters/getters at some point. Requires a lot of changes throughout rendering/.
GraphicsContext* context;
IntRect rect;
@@ -105,7 +100,6 @@ struct PaintInfo {
private:
const RenderLayerModelObject* m_paintContainer; // the layer object that originates the current painting
- ListHashSet<RenderInline*>* m_outlineObjects; // used to list outlines that should be painted by a block with inline children
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698