Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now. BUG=442514 Committed: https://crrev.com/200c95464e96ae99f3855c47dd8a7ca80fed620c Cr-Commit-Position: refs/heads/master@{#313230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M extensions/browser/api/cast_channel/logger.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/request_stage.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/warning_set.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/constants.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/permissions/base_set_operators.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/permission_message.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/permission_message_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/common/url_pattern.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-20 13:52:43 UTC) #2
anujsharma
@Kalman, Could you please help me in land this CL. PTAL Thanks!!
5 years, 11 months ago (2015-01-26 10:33:41 UTC) #4
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-26 16:14:21 UTC) #5
anujsharma
On 2015/01/26 16:14:21, kalman wrote: > lgtm Thanks kalman for lgtm.
5 years, 11 months ago (2015-01-27 03:23:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859993002/1
5 years, 11 months ago (2015-01-27 03:24:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 04:56:46 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 04:57:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/200c95464e96ae99f3855c47dd8a7ca80fed620c
Cr-Commit-Position: refs/heads/master@{#313230}

Powered by Google App Engine
This is Rietveld 408576698