extensions/browser/api/declarative_webrequest/request_stage.cc - Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/request_stage.cc

Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/declarative_webrequest/request_stage.cc

diff --git a/extensions/browser/api/declarative_webrequest/request_stage.cc b/extensions/browser/api/declarative_webrequest/request_stage.cc

index c49aab44dd90960234c57a68fc3fa7501b8e1f98..e58e8f359f34d08978e3ea833c468b0a49ef7166 100644

--- a/extensions/browser/api/declarative_webrequest/request_stage.cc

+++ b/extensions/browser/api/declarative_webrequest/request_stage.cc

@@ -17,7 +17,7 @@ const unsigned int kActiveStages = ON_BEFORE_REQUEST |

// |n| is a positive compile-time constant.

template <long unsigned int n>

struct HighestBit {

- COMPILE_ASSERT(n > 0, argument_is_not_a_positive_compile_time_constant);

+ static_assert(n > 0, "argument is not a positive compile time constant");

enum { VALUE = HighestBit<(n >> 1)>::VALUE << 1 };

};

template <>

« no previous file with comments | « extensions/browser/api/cast_channel/logger.cc ('k') | extensions/browser/warning_set.cc » ('j') | no next file with comments »