Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: extensions/browser/warning_set.cc

Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/declarative_webrequest/request_stage.cc ('k') | extensions/common/constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/warning_set.cc
diff --git a/extensions/browser/warning_set.cc b/extensions/browser/warning_set.cc
index 63dc5504a608e545be13111cdb7dc6e5ca4ed3ed..54c1c8bfc1431a9ee8729abbbfadaa7a11327006 100644
--- a/extensions/browser/warning_set.cc
+++ b/extensions/browser/warning_set.cc
@@ -204,7 +204,8 @@ std::string Warning::GetLocalizedMessage(const ExtensionSet* extensions) const {
final_parameters.push_back(base::UTF8ToUTF16(net::EscapeForHTML(message)));
}
- COMPILE_ASSERT(kMaxNumberOfParameters == 4u, YouNeedToAddMoreCaseStatements);
+ static_assert(kMaxNumberOfParameters == 4u,
+ "You Need To Add More Case Statements");
switch (final_parameters.size()) {
case 0:
return l10n_util::GetStringUTF8(message_id_);
« no previous file with comments | « extensions/browser/api/declarative_webrequest/request_stage.cc ('k') | extensions/common/constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698