extensions/common/permissions/base_set_operators.h - Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/base_set_operators.h

Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/permissions/base_set_operators.h

diff --git a/extensions/common/permissions/base_set_operators.h b/extensions/common/permissions/base_set_operators.h

index 38ff091870b2f4936fe5d1d99ba71ce7d4d3cf64..d18321ca0afb7852b03519b8f0187a4a3d29cb66 100644

--- a/extensions/common/permissions/base_set_operators.h

+++ b/extensions/common/permissions/base_set_operators.h

@@ -69,8 +69,8 @@ class BaseSetOperators {

BaseSetOperators() {

// Ensure |T| is convertible to us, so we can safely downcast when calling

// methods that must exist in |T|.

- COMPILE_ASSERT((base::is_convertible<T*, BaseSetOperators<T>*>::value),

- U_ptr_must_implicitly_convert_to_T_ptr);

+ static_assert((base::is_convertible<T*, BaseSetOperators<T>*>::value),

+ "U ptr must implicitly convert to T ptr");

}

BaseSetOperators(const T& set) {

« no previous file with comments | « extensions/common/constants.cc ('k') | extensions/common/permissions/permission_message.h » ('j') | no next file with comments »