extensions/common/permissions/permission_message.h - Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permission_message.h

Issue 859993002: Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/base_set_operators.h ('k') | extensions/common/permissions/permission_message_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/permission_message.h

diff --git a/extensions/common/permissions/permission_message.h b/extensions/common/permissions/permission_message.h

index fa65ab259e15cd326e9495964c4db6e7a08bea9a..04570bcbec92b10ac39efbf085b5acef34fd5f45 100644

--- a/extensions/common/permissions/permission_message.h

+++ b/extensions/common/permissions/permission_message.h

@@ -104,8 +104,8 @@ class PermissionMessage {

// "ExtensionPermission2" enum in tools/metrics/histograms/histograms.xml.

kEnumBoundary,

};

- COMPILE_ASSERT(PermissionMessage::kNone > PermissionMessage::kUnknown,

- kNone_not_greater_than_kUnknown);

+ static_assert(PermissionMessage::kNone > PermissionMessage::kUnknown,

+ "kNone should not greater than kUnknown");

// Creates the corresponding permission message.

PermissionMessage(ID id, const base::string16& message);

« no previous file with comments | « extensions/common/permissions/base_set_operators.h ('k') | extensions/common/permissions/permission_message_util.cc » ('j') | no next file with comments »