Issue 859203002: Merge Blink code to cache SkTextBlob

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -482 lines)			Patch
M	sky/engine/core/rendering/InlineTextBox.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/rendering/InlineTextBox.cpp	View	1	4 chunks	+16 lines, -6 lines	0 comments	Download
M	sky/engine/platform/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/platform/fonts/Font.h	View		4 chunks	+5 lines, -11 lines	0 comments	Download
M	sky/engine/platform/fonts/Font.cpp	View		6 chunks	+100 lines, -95 lines	0 comments	Download
M	sky/engine/platform/fonts/GlyphBuffer.h	View		3 chunks	+19 lines, -18 lines	0 comments	Download
D	sky/engine/platform/fonts/GlyphBufferTest.cpp	View		1 chunk	+0 lines, -237 lines	0 comments	Download
M	sky/engine/platform/fonts/harfbuzz/FontHarfBuzz.cpp	View		7 chunks	+52 lines, -74 lines	0 comments	Download
M	sky/engine/platform/fonts/harfbuzz/HarfBuzzShaper.h	View		5 chunks	+3 lines, -6 lines	0 comments	Download
M	sky/engine/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View		4 chunks	+28 lines, -30 lines	0 comments	Download
M	sky/engine/platform/graphics/GraphicsContext.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	sky/engine/platform/text/TextRun.h	View		3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

I have each of these merges separately in my local git repo, but there's a ...

5 years, 11 months ago (2015-01-21 09:12:37 UTC) #2

esprehn

lgtm, lets just land them all and iterate. We'll want to refactor all this code ...

5 years, 11 months ago (2015-01-21 09:58:57 UTC) #3

abarth-chromium

Committed patchset #2 (id:20001) manually as a74ca2e7797551931fdc4d55066394e93f965b70 (presubmit successful).

5 years, 11 months ago (2015-01-21 18:58:44 UTC) #4

abarth-chromium

5 years, 11 months ago (2015-01-21 19:30:35 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/859203002/diff/1/sky/engine/core/rendering/In...
File sky/engine/core/rendering/InlineTextBox.cpp (right):

https://codereview.chromium.org/859203002/diff/1/sky/engine/core/rendering/In...
sky/engine/core/rendering/InlineTextBox.cpp:68: static
InlineTextBoxBlobCacheMap* gTextBlobCache;
On 2015/01/21 at 09:58:57, esprehn wrote:
> Lets just add a ptr to InlineTextBox. I don't know why they didn't.

It was part of the first CL.  I think they were worried about adding memory
while the feature was off.  /me will change.

Expand Messages | Collapse Messages