Issue 856613002: Always use deferred text blob bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 856613002: Always use deferred text blob bounds. (Closed)

Created:
5 years, 11 months ago by jbroman

Modified:
5 years, 11 months ago

Reviewers:
f(malita)

CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Always use deferred text blob bounds. Currently our visual bounds are too often wrong, and letting Skia always compute them seems safer. Hopefully the Blink code gets cleaned up more in the future, but in the meantime this works, and shouldn't significantly regress performance since this value is cached. Cluster telemetry doesn't show a regression, either. BUG=444921 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188699

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -16 lines)			Patch
	M	LayoutTests/TestExpectations	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	Source/platform/fonts/Font.cpp	View	1	2 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856613002/40001

5 years, 11 months ago (2015-01-20 21:57:37 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-20 22:01:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188699

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 856613002: Always use deferred text blob bounds. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase against master #

Patch Set 3 : TestExpectations (progressions) #

Messages