Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 667573008: [TextBlob] Add support for offsets (i.e. complex text) to text blobs. (Closed)

Created:
6 years, 2 months ago by jbroman
Modified:
6 years, 2 months ago
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

[TextBlob] Add support for offsets (i.e. complex text) to text blobs. BUG=377845 TEST=No regression in layout tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M Source/platform/fonts/Font.cpp View 2 chunks +36 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
6 years, 2 months ago (2014-10-21 19:27:00 UTC) #2
jbroman
I used a template here because I want to avoid having an extra per-glyph branch; ...
6 years, 2 months ago (2014-10-21 19:28:03 UTC) #3
f(malita)
LGTM
6 years, 2 months ago (2014-10-21 21:34:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667573008/1
6 years, 2 months ago (2014-10-21 21:38:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 21:42:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184121

Powered by Google App Engine
This is Rietveld 408576698