Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 820093005: [TextBlob] Recompute blob bounds when empty. (Closed)

Created:
5 years, 11 months ago by f(malita)
Modified:
5 years, 11 months ago
Reviewers:
eae, jbroman
CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[TextBlob] Recompute blob bounds when empty. Blob bounds should never be empty, but we sometimes receive empty bounds for glyphs with logical width == 0. In this case, let Skia re-compute the correct bounds. (This is a stop-gap fix for http://crbug.com/445527. For a long term fix we need to investigate either a) using glyph overflow bounds instead of logical bounds or b) always defer bounds computation to Skia) BUG=445527 R=jbroman@chromium.org,eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/platform/fonts/Font.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jbroman
lgtm since it's temporary
5 years, 11 months ago (2015-01-08 23:38:19 UTC) #1
f(malita)
5 years, 11 months ago (2015-01-08 23:46:27 UTC) #2
eae
LGTM
5 years, 11 months ago (2015-01-09 00:28:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820093005/1
5 years, 11 months ago (2015-01-09 00:29:29 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:18:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188099

Powered by Google App Engine
This is Rietveld 408576698