Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 778233002: TextBlob: Use deferred bounds if negative letter or word spacing exists. (Closed)

Created:
6 years ago by jbroman
Modified:
6 years ago
Reviewers:
f(malita), eae
CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

TextBlob: Use deferred bounds if negative letter or word spacing exists. This is one case where we can wind up using layout bounds that aren't appropriate for a visual bounding box. It happens to have the particularly wrong effect of causing the text blob to be culled altogether. BUG=437121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M Source/platform/fonts/Font.cpp View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
This seems like the most straightforward way to deal with this issue right now. I ...
6 years ago (2014-12-06 23:34:09 UTC) #2
f(malita)
lgtm
6 years ago (2014-12-07 03:29:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778233002/1
6 years ago (2014-12-07 19:53:13 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-07 19:55:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186648

Powered by Google App Engine
This is Rietveld 408576698