Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 856563006: Remove background obscuration checks. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove background obscuration checks. This is an optimization to avoid painting backgrounds that are obscured. It's a lot of complexity that it's not clear we'll need given that we're using a GL backend. Also, we can add it back in more easily/efficiently in the future once we have a display list architecture. This also means we can remove the needsPaintInvalidation dirty bit and some opacity information on filters. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f28afffaab92fc88872671f56a53e3ad40df2258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -415 lines) Patch
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 4 chunks +0 lines, -136 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderImage.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 2 chunks +0 lines, -56 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 3 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 7 chunks +4 lines, -47 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 2 chunks +0 lines, -37 lines 0 comments Download
M sky/engine/core/rendering/style/StyleDifference.h View 2 chunks +1 line, -10 lines 0 comments Download
M sky/engine/platform/graphics/filters/FilterOperation.h View 5 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/platform/graphics/filters/FilterOperations.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/graphics/filters/FilterOperations.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 11 months ago (2015-01-16 01:10:39 UTC) #2
ojan
5 years, 11 months ago (2015-01-16 01:11:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f28afffaab92fc88872671f56a53e3ad40df2258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698