Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: sky/engine/platform/graphics/filters/FilterOperation.h

Issue 856563006: Remove background obscuration checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/platform/graphics/filters/FilterOperation.h
diff --git a/sky/engine/platform/graphics/filters/FilterOperation.h b/sky/engine/platform/graphics/filters/FilterOperation.h
index cd4ce6344d826c06f5424673b9ba5d3bf3450932..04f4dee67e4af3071efa8fc86c62a79b524dbedc 100644
--- a/sky/engine/platform/graphics/filters/FilterOperation.h
+++ b/sky/engine/platform/graphics/filters/FilterOperation.h
@@ -89,8 +89,6 @@ public:
OperationType type() const { return m_type; }
virtual bool isSameType(const FilterOperation& o) const { return o.type() == m_type; }
- // True if the alpha channel of any pixel can change under this operation.
- virtual bool affectsOpacity() const { return false; }
// True if the the value of one pixel can affect the value of another pixel under this operation, such as blur.
virtual bool movesPixels() const { return false; }
@@ -116,7 +114,6 @@ public:
return adoptRef(new ReferenceFilterOperation(url, fragment));
}
- virtual bool affectsOpacity() const override { return true; }
virtual bool movesPixels() const override { return true; }
const String& url() const { return m_url; }
@@ -203,8 +200,6 @@ public:
double amount() const { return m_amount; }
- virtual bool affectsOpacity() const override { return m_type == OPACITY; }
-
private:
virtual PassRefPtr<FilterOperation> blend(const FilterOperation* from, double progress) const override;
@@ -242,7 +237,6 @@ public:
const Length& stdDeviation() const { return m_stdDeviation; }
- virtual bool affectsOpacity() const override { return true; }
virtual bool movesPixels() const override { return true; }
@@ -280,7 +274,6 @@ public:
int stdDeviation() const { return m_stdDeviation; }
Color color() const { return m_color; }
- virtual bool affectsOpacity() const override { return true; }
virtual bool movesPixels() const override { return true; }
« no previous file with comments | « sky/engine/core/rendering/style/StyleDifference.h ('k') | sky/engine/platform/graphics/filters/FilterOperations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698