Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 856563006: Remove background obscuration checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/engine/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 return selectionColor(CSSPropertyWebkitTextEmphasisColor); 1192 return selectionColor(CSSPropertyWebkitTextEmphasisColor);
1193 } 1193 }
1194 1194
1195 void RenderObject::selectionStartEnd(int& spos, int& epos) const 1195 void RenderObject::selectionStartEnd(int& spos, int& epos) const
1196 { 1196 {
1197 view()->selectionStartEnd(spos, epos); 1197 view()->selectionStartEnd(spos, epos);
1198 } 1198 }
1199 1199
1200 StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff) const 1200 StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff) const
1201 { 1201 {
1202 // If transform, opacity or zIndex changed, then we need to invalidate paint s.
1203 // Text nodes share style with their parents but transform/opacity/z-index d on't apply to them,
1204 if (!isText() &&
1205 (diff.transformChanged() || diff.opacityChanged() || diff.zIndexChanged( ))) {
1206 diff.setNeedsPaintInvalidation();
1207 }
1208
1209 // If filter changed and it paints with filters, then we need to invalidate paints.
1210 if (diff.filterChanged() && hasLayer()) {
1211 diff.setNeedsPaintInvalidation();
1212 }
1213
1214 // The answer to layerTypeRequired() for plugins, iframes, and canvas can ch ange without the actual 1202 // The answer to layerTypeRequired() for plugins, iframes, and canvas can ch ange without the actual
1215 // style changing, since it depends on whether we decide to composite these elements. When the 1203 // style changing, since it depends on whether we decide to composite these elements. When the
1216 // layer status of one of these elements changes, we need to force a layout. 1204 // layer status of one of these elements changes, we need to force a layout.
1217 if (!diff.needsFullLayout() && style() && isLayerModelObject()) { 1205 if (!diff.needsFullLayout() && style() && isLayerModelObject()) {
1218 bool requiresLayer = toRenderLayerModelObject(this)->layerTypeRequired() != NoLayer; 1206 bool requiresLayer = toRenderLayerModelObject(this)->layerTypeRequired() != NoLayer;
1219 if (hasLayer() != requiresLayer) 1207 if (hasLayer() != requiresLayer)
1220 diff.setNeedsFullLayout(); 1208 diff.setNeedsFullLayout();
1221 } 1209 }
1222 1210
1223 return diff; 1211 return diff;
(...skipping 870 matching lines...) Expand 10 before | Expand all | Expand 10 after
2094 { 2082 {
2095 if (object1) { 2083 if (object1) {
2096 const blink::RenderObject* root = object1; 2084 const blink::RenderObject* root = object1;
2097 while (root->parent()) 2085 while (root->parent())
2098 root = root->parent(); 2086 root = root->parent();
2099 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 2087 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
2100 } 2088 }
2101 } 2089 }
2102 2090
2103 #endif 2091 #endif
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/engine/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698