Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: sky/engine/core/rendering/style/RenderStyle.cpp

Issue 856563006: Remove background obscuration checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.h ('k') | sky/engine/core/rendering/style/StyleDifference.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/style/RenderStyle.cpp
diff --git a/sky/engine/core/rendering/style/RenderStyle.cpp b/sky/engine/core/rendering/style/RenderStyle.cpp
index 745a422a7661e1ca17c10e1aeb83ff5afb5b7d9b..9c25b7a241cb9f9d458686c87b13a6eb6c51fdbd 100644
--- a/sky/engine/core/rendering/style/RenderStyle.cpp
+++ b/sky/engine/core/rendering/style/RenderStyle.cpp
@@ -299,9 +299,6 @@ StyleDifference RenderStyle::visualInvalidationDiff(const RenderStyle& other) co
diff.setNeedsFullLayout();
}
- if (!diff.needsFullLayout() && diffNeedsPaintInvalidation(other))
- diff.setNeedsPaintInvalidation();
-
updatePropertySpecificDifferences(other, diff);
// Cursors are not checked, since they will be set appropriately in response to mouse events,
@@ -462,40 +459,6 @@ bool RenderStyle::diffNeedsFullLayout(const RenderStyle& other) const
return false;
}
-bool RenderStyle::diffNeedsPaintInvalidation(const RenderStyle& other) const
-{
- if (inherited_flags._visibility != other.inherited_flags._visibility
- || !surround->border.visuallyEqual(other.surround->border)
- || !m_background->visuallyEqual(*other.m_background))
- return true;
-
- if (rareInheritedData.get() != other.rareInheritedData.get()) {
- if (rareInheritedData->userModify != other.rareInheritedData->userModify
- || rareInheritedData->userSelect != other.rareInheritedData->userSelect
- || rareInheritedData->m_imageRendering != other.rareInheritedData->m_imageRendering)
- return true;
- }
-
- if (rareNonInheritedData.get() != other.rareNonInheritedData.get()) {
- if (rareNonInheritedData->userDrag != other.rareNonInheritedData->userDrag
- || rareNonInheritedData->m_objectFit != other.rareNonInheritedData->m_objectFit
- || rareNonInheritedData->m_objectPosition != other.rareNonInheritedData->m_objectPosition
- || !dataEquivalent(rareNonInheritedData->m_clipPath, other.rareNonInheritedData->m_clipPath))
- return true;
- }
-
- if (position() != StaticPosition && (visual->clip != other.visual->clip || visual->hasAutoClip != other.visual->hasAutoClip))
- return true;
-
- if (rareNonInheritedData.get() != other.rareNonInheritedData.get()) {
- if (rareNonInheritedData->m_mask != other.rareNonInheritedData->m_mask
- || rareNonInheritedData->m_maskBoxImage != other.rareNonInheritedData->m_maskBoxImage)
- return true;
- }
-
- return false;
-}
-
void RenderStyle::updatePropertySpecificDifferences(const RenderStyle& other, StyleDifference& diff) const
{
// StyleAdjuster has ensured that zIndex is non-auto only if it's applicable.
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.h ('k') | sky/engine/core/rendering/style/StyleDifference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698